Adding tag, gray900 #571
Merged
Adding tag, gray900 #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
emilmilanov
commented
May 5, 2025
•
emilmilanov
commented
🦋 Changeset detectedLatest commit: 42841e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cypress-design
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress-design
|
| Branch Review |
tag-gray-900
|
| Run status |
|
| Run duration | 05m 29s |
| Commit |
|
| Committer | Emil Milanov |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
236
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
7.65%
|
|
|---|---|
|
Untested elements
|
298
|
|
Tested elements
|
26
|
Accessibility
99.43%
|
|
|---|---|
|
Failed rules
|
0 critical
2 serious
0 moderate
1 minor
|
|
Failed elements
|
23
|
ryanjwilke
reviewed
May 5, 2025
| @@ -17,6 +17,10 @@ export const CssColor = { | |||
| default: 'bg-gray-50 text-gray-700 border-gray-100', | |||
| dark: 'bg-gray-700 text-white border-gray-700', | |||
| }, | |||
| gray900: { | |||
There was a problem hiding this comment.
@emilmilanov I would recommend calling this one gray-dark maybe just to align closer to how we call our Button components.
|
PR is ready for a review @ryanjwilke I updated all tag variants to support outline. The only issue I see is that |
ryanjwilke
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.